feat: attestation extension for eligibility claims#264
feat: attestation extension for eligibility claims#264douglasborthwick-crypto wants to merge 2 commits intoUniversal-Commerce-Protocol:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@googlebot I signed it! |
5215efc to
23e496c
Compare
|
Hi @amithanda — just checking in on this one. Is there anything blocking review, or would adding the "TC review" label help get it into the queue? Happy to address any feedback. |
23e496c to
ea8e49f
Compare
ea8e49f to
5f10d2d
Compare
Adds a capability extension that complements eligibility (Universal-Commerce-Protocol#250) with cryptographic attestation proofs. Platforms relay signed attestations alongside eligibility claims; Businesses verify offline via JWKS. Follows the discount extension pattern (allOf on Cart/Checkout). Discussed in Universal-Commerce-Protocol#203 and Universal-Commerce-Protocol#250 — igrigorik invited this as a companion extension ("a great candidate, additive and non-breaking").
5f10d2d to
2e832ec
Compare
|
Reviewing as co-author of the related Ideas discussion [#298](#298) ( The wire format here is consistent with what we designed in #298. A few observations from the implementation side: Strong alignment with #298:
One implementation note: On Overall this PR is well-structured and the approach is sound. The |
|
Thanks for the review, and for linking this to #298 — the two proposals are designed to work together. On your two points: Payload serialization: The schema does include this — the
Appreciate the implementation-side validation — having an independent implementer confirm the wire format aligns with a production system is exactly the kind of feedback the TC looks for. |
…es_at Address review feedback from zologic (Universal-Commerce-Protocol#264 comment): - Promote payload opaqueness warning to top-level schema description - Add explicit "RFC 3339" to expires_at description, matching checkout.json
Description
Adds a capability extension that complements eligibility (#250) with
cryptographic attestation proofs for non-instrument claims (token holdings,
on-chain credentials, membership status).
Discussed and invited in #203 and #250:
provider_jwks/kid/payload/sigattestation pattern in the signals speccapability extension that complements eligibility. Additive and
non-breaking."
and specified the sibling map
pattern
— attestations keyed by eligibility claim, on the cart/checkout object
similar to the discount extension
How it works
context.eligibilityclaimsprovider_jwks, select key bykid, verifysigoverpayloadpayloadis an opaque passthrough of the provider's signed object — notransformation, so signature verification works end-to-end
expires_atlives outsidepayloadbecause it is not covered by thesignature — the Business checks this independently
Follows the discount extension pattern (
allOfon Cart and Checkout, siblingmap keyed by reverse-domain eligibility claims).
Wire format example
{ "context": { "eligibility": ["com.example.token_holder"] }, "attestations": { "com.example.token_holder": { "provider_jwks": "https://example.com/.well-known/jwks.json", "kid": "example-key-2026-01", "payload": { "id": "att-7c3e9f", "pass": true, "results": ["..."], "attestedAt": "2026-03-13T19:20:32.530Z" }, "sig": "base64...", "expires_at": "2026-03-13T19:50:32.530Z" } } }Verification flow
context.eligibilityclaim + matchingattestationsentryprovider_jwks, selects key matchingkidsigover the payload (platforms must preserve the provider'soriginal serialization)
expires_athasn't passedpayload.passto confirm the claim is metNo callback to the Platform or attestation provider required — fully offline.
Relationship to #280
This PR and #280 (wallet attestation mechanism type) are complementary but
independent:
data appears in cart/checkout wire format.
identity_linking— how a businessestablishes identity via wallet attestation.
Neither PR depends on the other. When both are present, the mechanism provides
the signed attestation and the extension provides the wire format for attaching
it.
Files Changed
source/schemas/shopping/attestation.jsonallOfType of change
Checklist